Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OpenMDAO install in GitHub Actions build #53

Merged
merged 9 commits into from
Jun 26, 2023
Merged

Fix OpenMDAO install in GitHub Actions build #53

merged 9 commits into from
Jun 26, 2023

Conversation

eytanadler
Copy link
Collaborator

Purpose

The OpenConcept biweekly build fails because OpenMDAO is no longer installing correctly. The error, which this PR fixes, is:

Collecting openmdao==3.10
  Downloading openmdao-3.10.0.tar.gz (5.1 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 5.1/5.1 MB [17](https://github.com/mdolab/openconcept/actions/runs/5225381507/jobs/9619604847#step:5:18).4 MB/s eta 0:00:00
  Preparing metadata (setup.py): started
  Preparing metadata (setup.py): finished with status 'error'
  error: subprocess-exited-with-error
  
  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [1 lines of output]
      error in openmdao setup command: 'extras_require' must be a dictionary whose values are strings or lists of strings containing valid project/version requirement specifiers.
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Maintenance update

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eytanadler eytanadler requested a review from a team as a code owner June 19, 2023 17:18
@codecov
Copy link

codecov bot commented Jun 19, 2023 •
edited
Loading

Codecov Report

Merging #53 (c61bfc0) into main (c92037e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage   79.99%   79.99%           
=======================================
  Files          85       85           
  Lines        9297     9297           
=======================================
  Hits         7437     7437           
  Misses       1860     1860

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eytanadler eytanadler changed the title Don't merge yet! Fix OpenMDAO install in GitHub Actions build Fix OpenMDAO install in GitHub Actions build Jun 19, 2023
@eytanadler
Copy link
Collaborator Author

Ready now. The tests that aren't running are expected. They're old requirements on the branch protection because the names have changed now that I pinned the setuptools version.

@eytanadler eytanadler mentioned this pull request Jun 19, 2023
Merged
13 tasks
bernardopacini
bernardopacini approved these changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@bernardopacini bernardopacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this fix.

@eytanadler eytanadler merged commit 34f5f94 into mdolab:main Jun 26, 2023
@eytanadler eytanadler deleted the om_build_fix branch June 26, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernardopacini bernardopacini bernardopacini approved these changes

@lamkina lamkina Awaiting requested review from lamkina lamkina is a code owner automatically assigned from mdolab/openconcept_maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eytanadler @bernardopacini